From 79d11bfdde29c8b8854dcaa585ffa2607c9e6abd Mon Sep 17 00:00:00 2001 From: Fred Brennan Date: Mon, 14 Nov 2022 06:37:52 -0500 Subject: [PATCH] Fix warnings Fix -Wimplicit-int errors with GCC 14: xcur2png.c: In function 'saveConfAndPNGs': xcur2png.c:674:10: error: type defaults to 'int' in declaration of 'dry_run' [-Wimplicit-int] 674 | extern dry_run; | ^~~~~~~ Upstream-Status: Submitted [https://github.com/eworm-de/xcur2png/pull/2] [ismael@sourcemage.org: Improved commit message] Signed-off-by: Ismael Luceno --- xcur2png.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/xcur2png.c b/xcur2png.c index 8723a10..00ff7cb 100644 --- a/xcur2png.c +++ b/xcur2png.c @@ -19,6 +19,7 @@ #include #define _ATFILE_SOURCE +#include #include #include #include @@ -38,8 +39,8 @@ #define PROGRESS_SHARPS 50 /* total number of progress sharps */ -int quiet = 0; /* 1: output is quiet, 0: not quiet */ -int dry_run = 0; /* 1:don't output PNGs and conf is output to stdout. */ +bool quiet = 0; /* 1: output is quiet, 0: not quiet */ +bool dry_run = 0; /* 1:don't output PNGs and conf is output to stdout. */ #define VERBOSE_PRINT(...) \ if (!quiet) { fprintf (stderr, __VA_ARGS__); } @@ -92,8 +93,8 @@ void parseOptions (int argc, char* argv[], char** confp, int ret; extern char *optarg; extern int optind; - extern int quiet; - extern int dry_run; + extern bool quiet; + extern bool dry_run; const struct option longopts[] = { {"version", no_argument, NULL, 'V'}, @@ -671,7 +672,7 @@ int saveConfAndPNGs (const XcursorImages* xcIs, const char* xcurFilePart, int su int ret; int count = 0; char pngName[PATH_MAX] = {0}; - extern dry_run; + extern bool dry_run; //Write comment on config-file. fprintf (conffp,"#size\txhot\tyhot\tPath to PNG image\tdelay\n");